Closed emilyjablonski closed 1 year ago
@slowbot Do we know for sure if we should support counters on the Tabs component? It's not a use case we have currently AFAIK. I guess it could be argued that if Menu supports counters, Tabs should, but I could also see an argument that if there needs to be counters on various tabs, maybe that's a content structure which would be better served by separate pages & menus anyway. Thoughts?
@jaredcwhite If counters are more complex then we drop them from tabs.
@slowbot This should be ready for a final QA in zeroheight now.
@jaredcwhite
@slowbot
@jaredcwhite I guess the current state is about being explicit about the aria labeling but can remove if it seems redundant.
In the future let me know if you recommend changes to the zeroheight docs in the ticket
@slowbot Sure, maybe we remove that then. For this particular component we're leveraging react-tabs which provides the right ARIA states (to the best of my knowledge).
I think it'd be cool if we could leverage zeroheight comments, but I guess we'd need to set up multiple user accounts there for that to work. (Right now when I modify things there I'm Jesse 😬)
@jaredcwhite LGTM!
Transfer the
Tabs
component from UIC to UISeeds. (Audit Link) (Figma Docs Link)We should make a few changes to the component on transfer: