bloom-housing / ui-seeds

Shared user interface components for Bloom affordable housing system
Apache License 2.0
1 stars 1 forks source link

feat: adopt Hero Icons as replacement for FontAwesome #74

Closed jaredcwhite closed 4 months ago

jaredcwhite commented 6 months ago

Issue Overview

This PR addresses #69

Description

This PR swaps out FontAwesome icons inside of various Seeds components with Hero Icons. In addition, it makes some adjustments to icon sizes (and introduces a "scale factor" option for consumers in case they have other custom icon requirements) to accomodate this change.

The Icon component also offers a new outlined prop which adds better support for coloring outlined SVGs as opposed to solid SVGs.

How Can This Be Tested/Reviewed?

Check out the Icon stories as well as other components which offer icons or can display icons such as Alert, Button, Dialog, Drawer, Link, Message, Tag, Toast.

Checklist:

netlify[bot] commented 6 months ago

Deploy Preview for storybook-ui-seeds ready!

Name Link
Latest commit d456cba7c0acd4c69308547c7c301c1f9211b4fb
Latest deploy log https://app.netlify.com/sites/storybook-ui-seeds/deploys/66296f429b440700087bef0e
Deploy Preview https://deploy-preview-74--storybook-ui-seeds.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jaredcwhite commented 5 months ago

@slowbot Sounds good, I updated the sizes and even pulled in the relevant size tokens. (FYI vertical-align values are a bit wonky, requires manual adjustment to look right. I think I got it though. Just a CSS thing I guess!)

github-actions[bot] commented 4 months ago

:tada: This PR is included in version 1.14.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: