search

bloom-lang / bud

Prototype Bud runtime (Bloom Under Development)
http://bloom-lang.net
Other
854 stars 60 forks source link

improved output (and, as a result, usefulness) of BudCollection#inspected #238

Closed michaelficarra closed 12 years ago

michaelficarra commented 12 years ago

old output:

["Alice", "Bob"]
["Bob", "Charlie"]
["Charlie", "Dave"]

new output:

nothing: []
people: [
  ("Alice", "Bob")
  ("Bob", "Charlie")
  ("Charlie", "Dave")]
neilconway commented 12 years ago

The patch causes several unit tests to fail (tc_collections, tc_mapvariants and tc_rebl).

The patch changes the definition of BudCollection#inspected but not BudJoin#inspected, which seems wrong.

Can you take a look at addressing those concerns and resubmit? Thanks.

michaelficarra commented 12 years ago

Oh, whoops. I didn't realise the unit tests would be testing that kind of output. I'll push new commits in a few minutes.

edit: more like a few hours

michaelficarra commented 12 years ago

@neilconway: how's that? I had trouble running the tests pre-change, so I'm not sure if they'll run properly for you, but I think I fixed the tests related to inspected output.

neilconway commented 12 years ago

Merged manually in 1c9670290ac7a41c3fc12e2f565d13eeb46cd839

michaelficarra commented 12 years ago

@neilconway: are you not worried about the failing test cases?

edit: never mind, just saw bce176e66db7f754db76f7fe75fec2b8b2588f45