search

bloom-works / guides-template

Placeholder repo for work on Bloom Guides
https://bloom-guides-template.netlify.app/
MIT License
2 stars 0 forks source link

Add base CSS styles #20

Closed jrubenoff closed 1 year ago

jrubenoff commented 1 year ago

Closes #12. I'm opening this PR now, before closing #5 and #6, because all my components depend on these base styles.

Changes

Most of these styles are pulled from jrubenoff/storybook-sass. Hopefully it has all the comments you need, but let me know if there's anything here that needs clarification.

@admoorgit If you want to leave feedback on typography, it's probably easiest to do so here!

jrubenoff commented 1 year ago

I should also mention that, in lieu of a build system, I'm using this tip to concatenate all my CSS files.

Might be nice to add minification down the line. @SMakaiTakori Let me know if there's a CSS build system you prefer!

jeffmaher commented 1 year ago

@admoorgit to jump in on this tomorrow. @SMakaiTakori to jump in later today.

netlify[bot] commented 1 year ago

Deploy Preview for bloom-guides-template ready!

Name Link
Latest commit 7dbc7549afe0cc35272a6d7b32a597d6577ee5a7
Latest deploy log https://app.netlify.com/sites/bloom-guides-template/deploys/649b3d308f94d50008bb4c7e
Deploy Preview https://deploy-preview-20--bloom-guides-template.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jrubenoff commented 1 year ago

@admoorgit I believe I've addressed everything here: https://typography--bloom-guides-template.netlify.app/

(I also added an example for caption text, to give you an idea of the smallest type size for some components.)

jrubenoff commented 1 year ago

@admoorgit I also just pushed up a fix for the H2's bottom border when the element spans multiple lines.

Before After
CleanShot 2023-06-23 at 08 19 39@2x CleanShot 2023-06-23 at 08 19 31@2x
jeffmaher commented 1 year ago

Updated the branch and applied a release label (and might do one more time after another PR is reviewed). Otherwise, ready for @admoorgit 's review.

jrubenoff commented 1 year ago

Adam says in Slack:

CleanShot 2023-06-27 at 10 13 07@2x

@admoorgit I've just pushed up those changes if you'd like to re-review and approve.

SMakaiTakori commented 1 year ago

@SMakaiTakori Had a late-breaking change to swap body copy from Condensed to regular Barlow for readability sake. S'ok for you?

TO BE DETERMINED: Removal of italic fonts (we may use bold instead), but need approval.

@admoorgit that works for me! We can always adjust the italic fonts later on.