search

bloom-works / guides-template

Placeholder repo for work on Bloom Guides
https://bloom-guides-template.netlify.app/
MIT License
2 stars 0 forks source link

Remove unused Eleventy starter files #58

Closed jeffmaher closed 1 year ago

jeffmaher commented 1 year ago

Pull Request Background

Removes stock files that came with the starter template used for this Eleventy distribution. Things like posts, tags, and RSS feeds not needed for a not-blog style setup.

What Changed

List any major changes to files and/or project functionality for this project.

How to Check Change

The code base should run as it did before, but with fewer files involved.

Automated Testing

Note: Cypress tests didn't run locally for me. I ran this inside the Docker container using sh ci/tests.sh. With that said, we should fix in a separate issue/PR:

image

netlify[bot] commented 1 year ago

Deploy Preview for bloom-guides-template ready!

Name Link
Latest commit 6a1c4ce9516316a819ba4d57298f3ff538cad690
Latest deploy log https://app.netlify.com/sites/bloom-guides-template/deploys/64edfc8a46d4e00007b96202
Deploy Preview https://deploy-preview-58--bloom-guides-template.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

SMakaiTakori commented 1 year ago

@jeffmaher Regarding your note about Cypress not running locally. I did add additional notes in the README doc concerning this. Let me know if this doesn't work but it should --->>>>>

Automated Testing - additional notes section at bottom of README If you are running Docker on your machine and get an error that Cypress is not installed and that it cannot find the cypress file at /root/.cache/Cypress/12.17.1/Cypress, this could be a permissions issue and you would run node_modules/.bin/cypress install inside of the Docker container to install Cypress.

jeffmaher commented 1 year ago

@jeffmaher Regarding your note about Cypress not running locally. I did add additional notes in the README doc concerning this. Let me know if this doesn't work but it should --->>>>>

Automated Testing - additional notes section at bottom of README If you are running Docker on your machine and get an error that Cypress is not installed and that it cannot find the cypress file at /root/.cache/Cypress/12.17.1/Cypress, this could be a permissions issue and you would run node_modules/.bin/cypress install inside of the Docker container to install Cypress.

@SMakaiTakori : Thanks for heads up -- I totally missed this and will do this in the future! Since this is a separate issue (and the tests run fine on GitHub), let me know if you have any comments/suggested changes for the file cleanup or if this PR is approved or not.