bloom-works / guides-template

Placeholder repo for work on Bloom Guides
https://bloom-guides-template.netlify.app/
MIT License
2 stars 0 forks source link

Remove Resources section from the footer #60

Closed jeffmaher closed 1 year ago

jeffmaher commented 1 year ago

Pull Request Background

Removes the Resources area from the footer for two reasons:

  1. Reduces maintenance upkeep for when we add new guides
  2. There's nothing really worth linking to yet

Can very easily be added back in the future if Guides or Writing winds up in our main website's nav structure and we want this to mirror that.

How to Check Change

The footer used to look like this:

image

It should now look like this:

image

netlify[bot] commented 1 year ago

Deploy Preview for bloom-guides-template ready!

Name Link
Latest commit 50596193276d07450fb58ba659a79ec9cdd98fa6
Latest deploy log https://app.netlify.com/sites/bloom-guides-template/deploys/64f22c1b240d1c0008370432
Deploy Preview https://deploy-preview-60--bloom-guides-template.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

SMakaiTakori commented 1 year ago

@jeffmaher This looks good to me code-wise. I will defer to @admoorgit on design since things don't appear centered anymore and the design may need to be updated.

admoorgit commented 1 year ago

Kind of a weird thing separate from the footer layout is, if you highlight the text in Safari, it becomes unreadable in some areas. It's fine in Chrome. Likely a browser-specific interpretation.

image
jeffmaher commented 1 year ago

@admoorgit : Sounds good! I'll code that up!

jeffmaher commented 1 year ago

@admoorgit : Coded up!

image

I created a separate ticket ( #62 ) to look into the highlighting bug. Makai and I both have Windows machines, so will track down a Mac to test on (read: Jeff steals his wife's computer).

admoorgit commented 1 year ago

Kinda late on responding but this looks good to me!