Closed jeffmaher closed 1 year ago
The outline for a single guide section can be quite long:
Ideally we'd avoid a situation where the Table of Contents exceeds the height of the page content, since that doesn't look great. (This page on 18F is one example.)
We also want to prevent this component from taking up a lot of space on small screens.
This feels like a great opportunity to use a <details>
/ <summary>
pattern. It lets us keep the screen real estate for this component small by default.
Here is an initial visual design:
Default state
Expanded state
The plus icon rotates as the component expands.
storybook
branch.markdown-it-anchor
and eleventy-plugin-nesting-toc
plugins. I'll open a PR once #5 and #6 are finished.@admoorgit I really like having numbered sections in the employee handbook. (See the above screenshots.) But for the discovery playbook, it doesn't look great:
Maybe it's be a good idea to remove the section numbers for the discovery playbook? Let me know what you think.
@jrubenoff yes!
@admoorgit Here's a version addressing all of the above. It has bold text, so it complies with AA Large:
Even with the extra padding, it still takes up less space than the previous design given the smaller font size. LMK what you think!
Howdy @jrubenoff ! Spoke with Jeff on Friday and here's where we landed:
Let me know if you have questions!
Single-column layout:
Multi-column layout (collapses to one column on smaller screens:)
@admoorgit All your other feedback should be addressed in the above screenshots. Let me know which you prefer!
@admoorgit to hop into today.
@jrubenoff I dig I dig! I prefer 2-column that collapses into single at smaller widths.
2 tweaks, and no need for me to review again unless you have a question:
This is looking really good! You rock!
Waiting for review from @admoorgit and a merge conflict for @SMakaiTakori or @LynnHerrick9 .
I resolved the conflicts in this PR and it is now merged!
Stories
Notes
Done When