search

bloomberg / attrs-strict

Provides runtime validation of attributes specified in Python 'attr'-based data classes.
Apache License 2.0
52 stars 19 forks source link

Remove Travis #44

Closed gaborbernat closed 4 years ago

gaborbernat commented 4 years ago

@kpfleming you'll need to remove the Travis check requirement for this.

kpfleming commented 4 years ago

The 'required' check has been disabled. I haven't stopped Travis-CI from making builds yet, but that can be done as soon as you are comfortable that the Actions workflows have replaced it.

gaborbernat commented 4 years ago

@erikseulean can you approve, I think Github has with this entirely replaced Travis.

kpfleming commented 4 years ago

There's going to be a small ongoing complication with this: using Actions you are able to define the names of the workflows and jobs, but you aren't able to control the jobs that are marked 'required' in the branch protection settings (because that is handled via automation). Once we setup branch protection to 'require' one or more Actions workflows to be successful for a PR to be mergeable, if you change the workflow or job names then the PRs will stop being mergeable because they'll be looking for the old names.

In other words: be certain that you are happy with your workflow/job names now :-)

gaborbernat commented 4 years ago

On my side I'm happy.

erikseulean commented 4 years ago

To be fair, I don't see those changing very often so I'm happy with them as they are as well.

kpfleming commented 4 years ago

OK, if you look at the list of 'checks passed' on this PR, which ones do you want marked as 'required' for a PR to be mergeable?

erikseulean commented 4 years ago

I'd say lint, 3.8 and 3.7 . I'm not sure about the check docs tbh. @gaborbernat ?

erikseulean commented 4 years ago

I'd say lint, 3.8 and 3.7 . I'm not sure about the check docs tbh. @gaborbernat ?

gaborbernat commented 4 years ago

lint and 3.8 for me it's enough; in practice we'll not merge either way if any failed 👍

kpfleming commented 4 years ago

Done.