search

bloomberg / attrs-strict

Provides runtime validation of attributes specified in Python 'attr'-based data classes.
Apache License 2.0
52 stars 19 forks source link

Added funcsigs>=1.0.2 for python_version<3.5 #50

Closed lironhl closed 4 years ago

lironhl commented 4 years ago

49

Describe your changes Added funcsigs package to setup.cfg, to be required when installing attrs-strict from python<3.5.

Testing performed Ran the package in Python2.7 and in Python3.4 with funcsigs installed.

additional context Even though Python 2.7.18 introduced inspect in the standard library it lacks the signature function used in this package.

erikseulean commented 4 years ago

Thanks for this. Checking why the lint is failing.

erikseulean commented 4 years ago

I think that step should use the python3.8 interpreter rather than the 3.7 one.

gaborbernat commented 4 years ago

https://github.com/bloomberg/attrs-strict/blob/master/.pre-commit-config.yaml#L14 should be python3.7, probably the underlying image we run changed and exposed this bug.

erikseulean commented 4 years ago

We can flip to run it using Python3.8, any downsides of that ?

erikseulean commented 4 years ago

@lironhl would you mind rebasing please, it should fix the build.

lironhl commented 4 years ago

@lironhl would you mind rebasing please, it should fix the build.

Sorry for not being present in order to make the rebase myself, thank you for merging my changes!