search

bloomberg / attrs-strict

Provides runtime validation of attributes specified in Python 'attr'-based data classes.
Apache License 2.0
52 stars 19 forks source link

Python 3.9 support #55

Closed gaborbernat closed 4 years ago

gaborbernat commented 4 years ago

We shouldn't have merged this, master is broken now. We should have filled PRs against this branch until it passes.

erikseulean commented 4 years ago

Hmm, I did it because 3.9 is not mandatory and also it's still in dev. However I think there's a bug in the version check:

(work) eseulean attrs-strict (master) $ python2.7
Python 2.7.10 (default, Feb 22 2019, 21:55:15) 
[GCC 4.2.1 Compatible Apple LLVM 10.0.1 (clang-1001.0.37.14)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import subprocess; import json
>>> major, minor, impl = json.loads(subprocess.check_output(["python", "-c", "import json; import sys; import platform; print(json.dumps([sys.version_info[0], sys.version_info[1], platform.python_implementation()]));"], universal_newlines=True))
>>> major
3
erikseulean commented 4 years ago

Ah ignore that.