search

bloomberg / bde

Basic Development Environment - a set of foundational C++ libraries used at Bloomberg.
Apache License 2.0
1.68k stars 318 forks source link

Don't rely on implicit conversion from std::string_view to std::string #278

Closed tblah closed 2 years ago

tblah commented 2 years ago

Describe your changes Implicit conversion from std::string_view to std::string appears not to be the standard but is implemented in most standard libraries. The issue was found building bde on Windows using clang.

Testing performed Build completes successfully.

tblah commented 2 years ago

@joshuaberne

mversche commented 2 years ago

This change seems straight forward. We will run it through our platform build matrix just to confirm.

mversche commented 2 years ago

Per above, an analogous change has been merged to the master branch, so we will close this PR. If there are issues please let us know.