search

bloomberg / blazingmq-sdk-python

Python SDK for BlazingMQ, a modern high-performance open source message queuing system.
https://bloomberg.github.io/blazingmq/
Apache License 2.0
23 stars 6 forks source link

Add typechecking to the CI #6

Closed pniedzielski closed 9 months ago

pniedzielski commented 9 months ago

Our Python SDK makes use of type annotations throughout, but currently we do not check that these annotations are correct. Using mypy, we can check these type annotations statically. This is a good candidate for our CI checks, along with our other linters.

We have some minor typechecking errors in the codebase, especially relating to covariance, which should be fixed along with this.

pniedzielski commented 9 months ago

It looks like we only typecheck our examples: https://github.com/bloomberg/blazingmq-sdk-python/blob/d3e3f4302f9bb20429ff410ec1925293c06aa873/Makefile#L89