search

bloomberg / blazingmq

A modern high-performance open source message queuing system
https://bloomberg.github.io/blazingmq/
Apache License 2.0
2.5k stars 124 forks source link

Fix: add checks to pointer arguments in `m_bmqtool_inpututil` #81

Closed 678098 closed 8 months ago

678098 commented 11 months ago

Is there an existing proposal for this?

Is your feature request related to a problem?

Files: m_bmqtool_inpututil.h and m_bmqtool_inpututil.cpp

There are functions with arguments passed as a pointer, with assumption that these pointer values are not null.

Example:

https://github.com/bloomberg/blazingmq/blob/9b692fe25f74543e954a27e30b6b15b0ae057c8d/src/applications/bmqtool/m_bmqtool_inpututil.cpp#L50-L53

Describe the solution you'd like

Add checks to pointer arguments to functions in m_bmqtool_inpututil.

Example:

https://github.com/bloomberg/blazingmq/blob/9b692fe25f74543e954a27e30b6b15b0ae057c8d/src/groups/mqb/mqbmock/mqbmock_cluster.cpp#L380-L384

Alternatives you considered

No response

Dyex719 commented 9 months ago

Seems like a simple fix. Can I take this up?

678098 commented 9 months ago

Hi @Dyex719 ! Thanks for your interest, you can proceed with this. Just a gentle reminder, we have a DCO check for all commits in PR, the simple instruction is here: https://github.com/bloomberg/blazingmq/blob/main/CONTRIBUTING.md#contribution-licensing

678098 commented 8 months ago

Hi @Dyex719! Do you plan to solve this issue?

Dyex719 commented 8 months ago

How can I test these changes?

678098 commented 8 months ago

How can I test these changes?

The PR is good, merged.

Thank you @Dyex719 for your contribution!