search

bloomberg / clangmetatool

A framework for reusing code in Clang tools
https://bloomberg.github.io/clangmetatool/
Apache License 2.0
119 stars 25 forks source link

Port to clang-7 #23

Closed envp closed 5 years ago

envp commented 5 years ago

Signed-off-by: Vaibhav Yenamandra vyenamandra@bloomberg.net

envp commented 5 years ago

The test suite reproducibly segfaults with clang-7(clang version 7.0.0 (tags/RELEASE_700/final)), but builds (and passes) with gcc-7.3.1 (gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)).

Should the compiler suite be changed to gcc, or do we defer this for now?

Update: Done

ruoso commented 5 years ago

Come to think of it, we will need it to work on both clang 6 and clang 7 in parallel for a while. I think we need to add the old signature as well, otherwise it's not going to work...