bloomberg / comdb2

Bloomberg's distributed RDBMS
Other
1.39k stars 214 forks source link

Unregister modsnap txns from crashed clients #4828

Closed morgando closed 1 week ago

morgando commented 2 weeks ago

There is a bug where a modsnap transaction isn't removed from the database's list of outstanding modsnap transactions if the client crashes. This holds up log deletion.

The changes in this PR expose and fix this bug.

morgando commented 1 week ago

cdb2test Nov 7 17:41:06 2024 in-comdb2db clnt_crash_modsnap.R20241107.6

morgando commented 1 week ago

Thanks!