search

bloomberg / goldpinger

Debugging tool for Kubernetes which tests and displays connectivity between nodes in the cluster.
Apache License 2.0
2.5k stars 177 forks source link

[feature request] topology.kubernetes.io values in metrics #84

Open mtougeron opened 4 years ago

mtougeron commented 4 years ago

It would be awesome if the metrics could include the node's topology.kubernetes.io/region & topology.kubernetes.io/zone (not sure what the non-AWS fields are called). That would help quickly identify patterns in the results. e.g., zone "a" is slower than zone "b" or that cross-zone traffic is what's causing a large spike in response times. Not sure if this is possible within the framework of this tool.

keep up the great work & thank you!

seeker89 commented 4 years ago

These annotations seem to be popular.

I think that's a great idea. It would need to (optionally) broaden the privs to also list nodes, and then match its own pod to the node to populate the extra labels. It's a 👍 from me.

Now just someone needs to find a couple of hours to add it :)

mtougeron commented 4 years ago

haha the even present "find the time" bug. i hear that. :)

xlanor commented 2 years ago

@seeker89 I'd like to work on this as I do have some spare time. As I'm relatively new to the project and code base, which are some of the files I should be taking a look at?

patsevanton commented 5 months ago

A very necessary feature. Any updates?