search

bloomberg / goldpinger

Debugging tool for Kubernetes which tests and displays connectivity between nodes in the cluster.
Apache License 2.0
2.53k stars 180 forks source link

feat: configurable namespace for pod discovery #98

Closed sethp-verica closed 3 years ago

sethp-verica commented 3 years ago

Describe your changes Adds a configuration option to allow for cross-namespace pings.

Our intention is to mainly use '' ("all namespaces") to handle connectivity probing between namespace-scoped things (network policies, policy-driven webhooks, etc.). I also expect that setting the value to a namespace other than the one containing the pod ran in something of an "query only" mode, in that it aggregates results without showing up in the others' ping targets.

Testing performed I ran Goldpinger pods both with and without the new configuration: without, the pod successfully discovered itself in its own namespace (nothing else was running there), and with the value set to '' they successfully discovered each other across a namespace boundary.

Additional context The "all-namespaces" behavior is really what I'm after; if y'all would prefer an --all-namespaces flag to an explicit namespace, I'm happy to make that change.

seeker89 commented 3 years ago

This makes sense. I'll take it for a spin when I get a chance. Thanks, @sethp-verica !