bloomberg / memray

Memray is a memory profiler for Python
https://bloomberg.github.io/memray/
Apache License 2.0
13.17k stars 392 forks source link

Change the controls of the live reporter #429

Closed ivonastojanovic closed 1 year ago

ivonastojanovic commented 1 year ago

Changed the controls of the live reporter view for pausing and unpausing to use the same button as a toggle.

Issue number of the reported bug or feature request: #

Describe your changes A clear and concise description of the changes you have made.

Testing performed Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.

Additional context Add any other context about your contribution here.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.25% :warning:

Comparison is base (d04e103) 91.74% compared to head (418e233) 91.49%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #429 +/- ## ========================================== - Coverage 91.74% 91.49% -0.25% ========================================== Files 90 90 Lines 10503 10503 Branches 1448 1446 -2 ========================================== - Hits 9636 9610 -26 - Misses 864 890 +26 Partials 3 3 ``` | Flag | Coverage Δ | | |---|---|---| | cpp | `84.52% <ø> (-0.75%)` | :arrow_down: | | python_and_cython | `95.18% <50.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/bloomberg/memray/pull/429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg) | Coverage Δ | | |---|---|---| | [src/memray/commands/live.py](https://app.codecov.io/gh/bloomberg/memray/pull/429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg#diff-c3JjL21lbXJheS9jb21tYW5kcy9saXZlLnB5) | `77.35% <0.00%> (+2.81%)` | :arrow_up: | | [src/memray/reporters/tui.py](https://app.codecov.io/gh/bloomberg/memray/pull/429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg#diff-c3JjL21lbXJheS9yZXBvcnRlcnMvdHVpLnB5) | `98.85% <75.00%> (-0.38%)` | :arrow_down: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/bloomberg/memray/pull/429/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.