bloomberg / memray

Memray is a memory profiler for Python
https://bloomberg.github.io/memray/
Apache License 2.0
13.17k stars 392 forks source link

Rename flamegraph "Invert" button #456

Closed godlygeek closed 1 year ago

godlygeek commented 1 year ago

We've adding a --inverted mode to memray flamegraph causing stacks to be added to the flame graph in reverse order, so that the children of the root are functions that performed allocations and the leaves are thread entry points. Because of this change, we need a different name for the "Invert" button that flips the entire flame graph upside down.

This commit introduces a new toggle button for switching between our default "icicle graph" view (with the root at the top and allocations dangling from it) and the traditional "flame graph" view (with the root at the bottom and allocations rising up from it). The toggle button also gives a visual indication of what mode you're in.

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (514af3e) 91.84% compared to head (7be5c45) 91.85%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #456 +/- ## ======================================= Coverage 91.84% 91.85% ======================================= Files 90 90 Lines 10767 10767 Branches 1474 1474 ======================================= + Hits 9889 9890 +1 + Misses 876 875 -1 Partials 2 2 ``` | [Flag](https://app.codecov.io/gh/bloomberg/memray/pull/456/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg) | Coverage Δ | | |---|---|---| | [cpp](https://app.codecov.io/gh/bloomberg/memray/pull/456/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg) | `85.15% <ø> (+0.02%)` | :arrow_up: | | [python_and_cython](https://app.codecov.io/gh/bloomberg/memray/pull/456/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg) | `95.29% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1 file with indirect coverage changes](https://app.codecov.io/gh/bloomberg/memray/pull/456/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.