bloomberg / memray

Memray is a memory profiler for Python
https://bloomberg.github.io/memray/
Apache License 2.0
13.17k stars 392 forks source link

Leverage pkg-config in setup.py #498

Closed pablogsal closed 10 months ago

pablogsal commented 10 months ago

Using pkg-config we can get automatically the build flags in MacOS and Linux and this doesn't require the user to manually modify CFLAGS just to build the extension.

Signed-off-by: Pablo Galindo pablogsal@gmail.com

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (986a17e) 92.34% compared to head (c7a0573) 92.20%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #498 +/- ## ========================================== - Coverage 92.34% 92.20% -0.14% ========================================== Files 91 91 Lines 11033 11033 Branches 1524 1524 ========================================== - Hits 10188 10173 -15 - Misses 840 855 +15 Partials 5 5 ``` | [Flag](https://app.codecov.io/gh/bloomberg/memray/pull/498/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg) | Coverage Δ | | |---|---|---| | [cpp](https://app.codecov.io/gh/bloomberg/memray/pull/498/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg) | `85.61% <ø> (-0.41%)` | :arrow_down: | | [python_and_cython](https://app.codecov.io/gh/bloomberg/memray/pull/498/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg) | `95.48% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.