Closed cclauss closed 10 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
c4b35f3
) 92.32% compared to head (b556a9a
) 92.22%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Everything under benchmarks/ is vendored code that we don't want to modify - please revert the changes to those files. We should instead configure ruff to not lint that directory. Also, we should configure ruff to always apply the C4 and PERF rules if we're going to make these changes, since otherwise there's nothing stopping us from regressing on them.
All the changes to our source code and tests seem fine, though. I think some of the dictionary literals are a bit less readable than the calls to the dict() constructor they're replacing, but the difference is probably not enough to worry about.
Issue number of the reported bug or feature request: #
Describe your changes A clear and concise description of the changes you have made. Make minor performance improvements using ruff rules C4 and PERF.
Testing performed Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned. %
ruff --select=C4,PERF .
Additional context Add any other context about your contribution here.