Closed cclauss closed 10 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
138d9c5
) 92.24% compared to head (e9bc3d7
) 92.24%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Whoops, both of us made a change at the same time there.
@cclauss Why the downgrade of mirrors-prettier
to v2.7.1
?
Why the downgrade of mirrors-prettier to v2.7.1 ?
https://github.com/bloomberg/memray/actions/runs/6984049688/job/19006277652 which made no sense to me because Node.js v16 was indeed installed.
Ah, "prettier requires at least version 14 of Node, please upgrade". Hm. But we're installing Node 16...
Run actions/setup-node@v4
with:
node-version: 16
always-auth: false
check-latest: false
token: ***
Found in cache @ /opt/hostedtoolcache/node/16.[2](https://github.com/bloomberg/memray/actions/runs/6984188977/job/19006591456?pr=501#step:3:2)0.2/x6[4](https://github.com/bloomberg/memray/actions/runs/6984188977/job/19006591456?pr=501#step:3:4)
Environment details
node: v1[6](https://github.com/bloomberg/memray/actions/runs/6984188977/job/19006591456?pr=501#step:3:6).20.2
npm: [8](https://github.com/bloomberg/memray/actions/runs/6984188977/job/19006591456?pr=501#step:3:9).1[9](https://github.com/bloomberg/memray/actions/runs/6984188977/job/19006591456?pr=501#step:3:10).4
yarn: 1.22.21
Hm. I guess pre-commit isn't picking up the version that we installed...
I tend to use https://pre-commit.ci instead of GHA to run pre-commit.
I think I've got it. nodeenv
prefers a binary named nodejs
over one named node
:
And actions/setup-node
isn't installing a nodejs
, but there is one in /usr/bin on the runner, so that's getting chosen over the node
we've just installed.
It seems we can hack around it by symlinking the node
we install to nodejs
, which, yuck, but oh well it seems to work...
I've entered https://github.com/actions/setup-node/issues/905 for that since that doesn't seem like expected behavior (though I'm not a JS person so it's entirely possible this is a nodeenv problem and not an actions/setup-node problem... we'll see)
Issue number of the reported bug or feature request: #
500
Describe your changes A clear and concise description of the changes you have made. %
pre-commit autoupdate
Testing performed Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned. %
pre-commit run --all-files
Additional context Add any other context about your contribution here.