search

bloomberg / memray

Memray is a memory profiler for Python
https://bloomberg.github.io/memray/
Apache License 2.0
13.17k stars 392 forks source link

Publish manylinux2010 wheels for Python 3.11/3.12 #510

Closed godlygeek closed 7 months ago

godlygeek commented 9 months ago

We can't get this for free from the manylinux2010 image, because support for it was dropped before Python 3.11 came out. We can spin up a container based on that image, install Python 3.11 and 3.12 in it, and then ask cibuildwheel to use it for building some wheels for us (and running auditwheel repair and tests).

We'll do it only for x86_64, not i686, since 64-bit is much more heavily used.

codecov-commenter commented 9 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (41248ed) 92.55% compared to head (079b44e) 92.86%. Report is 17 commits behind head on main.

Files Patch % Lines
src/memray/reporters/tree.py 72.72% 3 Missing :warning:
tests/integration/test_extensions.py 90.47% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #510 +/- ## ========================================== + Coverage 92.55% 92.86% +0.31% ========================================== Files 91 91 Lines 11304 11134 -170 Branches 1581 2024 +443 ========================================== - Hits 10462 10340 -122 + Misses 837 794 -43 + Partials 5 0 -5 ``` | [Flag](https://app.codecov.io/gh/bloomberg/memray/pull/510/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg) | Coverage Δ | | |---|---|---| | [cpp](https://app.codecov.io/gh/bloomberg/memray/pull/510/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg) | `92.86% <92.75%> (+6.92%)` | :arrow_up: | | [python_and_cython](https://app.codecov.io/gh/bloomberg/memray/pull/510/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg) | `92.86% <92.75%> (-2.86%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pablogsal commented 7 months ago

LGTM

Hopefully we don't need to maintain this for long as it's quite involved. I reviewed and also tested this locally and in a container so I am confident it works but it's indeed a bit complex.