search

bloomberg / memray

Memray is a memory profiler for Python
https://bloomberg.github.io/memray/
Apache License 2.0
13.17k stars 392 forks source link

Update `upload-artifact` and `download-artifact`: one artifact per OS + arch + platform tag series #516

Closed sarahmonod closed 8 months ago

sarahmonod commented 8 months ago

Another approach for #513 where we use one artifact per OS + architecture instead of one per wheel.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (853df63) 92.44% compared to head (6b4974d) 92.32%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #516 +/- ## ========================================== - Coverage 92.44% 92.32% -0.12% ========================================== Files 91 91 Lines 11270 11270 Branches 1571 1571 ========================================== - Hits 10418 10405 -13 - Misses 847 860 +13 Partials 5 5 ``` | [Flag](https://app.codecov.io/gh/bloomberg/memray/pull/516/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg) | Coverage Δ | | |---|---|---| | [cpp](https://app.codecov.io/gh/bloomberg/memray/pull/516/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg) | `85.66% <ø> (-0.36%)` | :arrow_down: | | [python_and_cython](https://app.codecov.io/gh/bloomberg/memray/pull/516/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg) | `95.53% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sarahmonod commented 8 months ago

@godlygeek this is also ready to review. A test in Alpine is failing, but I am pretty confident it has nothing to do with this PR.

godlygeek commented 8 months ago

A test in Alpine is failing, but I am pretty confident it has nothing to do with this PR.

Passed on re-run. Yeah, I've seen that fail a few times - a segfault in the memray attach tests... 😔

godlygeek commented 8 months ago

OK, I think this should be good to go (other than updating the required status checks, which I'll do last). Double check the work on my commits for me, please, @gusmonod! 🚀