search

bloomberg / memray

Memray is a memory profiler for Python
https://bloomberg.github.io/memray/
Apache License 2.0
13.17k stars 392 forks source link

Use new GitHub native aarch64 macOS runners #539

Closed pablogsal closed 7 months ago

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (41248ed) 92.55% compared to head (0b15e51) 92.50%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #539 +/- ## ========================================== - Coverage 92.55% 92.50% -0.05% ========================================== Files 91 91 Lines 11304 11304 Branches 1581 1581 ========================================== - Hits 10462 10457 -5 - Misses 837 842 +5 Partials 5 5 ``` | [Flag](https://app.codecov.io/gh/bloomberg/memray/pull/539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg) | Coverage Δ | | |---|---|---| | [cpp](https://app.codecov.io/gh/bloomberg/memray/pull/539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg) | `85.80% <ø> (-0.14%)` | :arrow_down: | | [python_and_cython](https://app.codecov.io/gh/bloomberg/memray/pull/539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg) | `95.72% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pablogsal commented 7 months ago

I tested the arm macOS wheels in older macOS versions (Ventura) thanks to @ambv:

3.11:

-------------------------------------------------------------------------------------------------------- snapshot report summary --------------------------------------------------------------------------------------------------------
19 snapshots passed.
============================================================================================== 586 passed, 15 skipped in 72.49s (0:01:12) ===============================================================================================

and 3.12:

-------------------------------------------------------------------------------------------------------- snapshot report summary --------------------------------------------------------------------------------------------------------
19 snapshots passed.
============================================================================================== 588 passed, 13 skipped in 89.35s (0:01:29) ===============================================================================================
pablogsal commented 7 months ago

@godlygeek I think we can be confident that this won't explode in older versions so I think we can proceed with this (you need to approve the PR for it to land)