bloomberg / memray

Memray is a memory profiler for Python
https://bloomberg.github.io/memray/
Apache License 2.0
13.36k stars 397 forks source link

Fix live updates to footers on Textual TUIs #597

Closed godlygeek closed 5 months ago

godlygeek commented 6 months ago

In Textual 0.61, App.namespace_bindings was removed in favor of Screen.active_bindings. Update our implementation of dynamically updating footer descriptions to work for both, since we still support Textual versions below 0.61.

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 80.95238% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 92.86%. Comparing base (41248ed) to head (47e859c). Report is 38 commits behind head on main.

Files Patch % Lines
src/memray/reporters/tui.py 76.00% 6 Missing :warning:
src/memray/reporters/tree.py 79.16% 5 Missing :warning:
src/memray/reporters/_textual_hacks.py 92.85% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #597 +/- ## ========================================== + Coverage 92.55% 92.86% +0.30% ========================================== Files 91 92 +1 Lines 11304 11234 -70 Branches 1581 2055 +474 ========================================== - Hits 10462 10432 -30 + Misses 837 802 -35 + Partials 5 0 -5 ``` | [Flag](https://app.codecov.io/gh/bloomberg/memray/pull/597/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg) | Coverage Δ | | |---|---|---| | [cpp](https://app.codecov.io/gh/bloomberg/memray/pull/597/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg) | `92.86% <80.95%> (+6.92%)` | :arrow_up: | | [python_and_cython](https://app.codecov.io/gh/bloomberg/memray/pull/597/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg) | `92.86% <80.95%> (-2.86%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.