bloomberg / memray

Memray is a memory profiler for Python
https://bloomberg.github.io/memray/
Apache License 2.0
13.17k stars 392 forks source link

Reintroduce debuginfod deadlock workaround #635

Closed godlygeek closed 3 months ago

godlygeek commented 3 months ago

While switching from referencing the system debuginfod client library to vendoring our own copy of it, I removed a hack that turns out to still be required for some libc versions, because I incorrectly thought it only applied to the case when debuginfod was being loaded with dlopen.

Closes #634

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.02%. Comparing base (41248ed) to head (af85883). Report is 90 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #635 +/- ## ========================================== + Coverage 92.55% 93.02% +0.47% ========================================== Files 91 94 +3 Lines 11304 11412 +108 Branches 1581 2089 +508 ========================================== + Hits 10462 10616 +154 + Misses 837 796 -41 + Partials 5 0 -5 ``` | [Flag](https://app.codecov.io/gh/bloomberg/memray/pull/635/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg) | Coverage Δ | | |---|---|---| | [cpp](https://app.codecov.io/gh/bloomberg/memray/pull/635/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg) | `93.02% <100.00%> (+7.08%)` | :arrow_up: | | [python_and_cython](https://app.codecov.io/gh/bloomberg/memray/pull/635/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg) | `93.02% <100.00%> (-2.70%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

godlygeek commented 3 months ago

@ZeroIntensity confirmed for me that the wheels built by this CI run do in fact fix #634.