codecov-commenter
commented
1 month ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.97%. Comparing base (
29daff6) to head (e9c5d8c).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #670 +/- ## ========================================== - Coverage 93.00% 92.97% -0.03% ========================================== Files 94 94 Lines 11445 11445 Branches 2114 2114 ========================================== - Hits 10644 10641 -3 - Misses 801 804 +3 ``` | [Flag](https://app.codecov.io/gh/bloomberg/memray/pull/670/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg) | Coverage Δ | | |---|---|---| | [cpp](https://app.codecov.io/gh/bloomberg/memray/pull/670/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg) | `92.97% <ø> (-0.03%)` | :arrow_down: | | [python_and_cython](https://app.codecov.io/gh/bloomberg/memray/pull/670/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg) | `92.97% <ø> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Disable the
memray attachtests in cibuildwheel. These tests have broken because of changes to the GitHub runners. The old debuggers being installed in the containers are not compatible with the new Linux kernel being used by the runners. Rather than spend a bunch of effort to get this working, we'll just disable these tests in those environments.Note that we still exercising attaching with both debuggers in other workflows: the
test_with_coverageworkflow tests both gdb and lldb on glibc, and thetest_on_alpineworkflow tests both gdb and lldb on musl libc.Additionally, ensure "Build and test wheels" can fail. We added the "Build and test wheels" job as a required check to our CI in order to avoid needing to list every possible matrix job as required, but this didn't actually work as intended: the job never failed, it always either passed or was skipped, and GitHub doesn't count a skipped job as a failing check.
Work around this with a different approach: ensure that this job always runs, and succeeds if and only if all of its dependencies succeeded.