Closed sarahmonod closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
6e3dd1e
) 89.76% compared to head (a892112
) 89.71%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
To the reviewer(s):
aarch64
at all because I can't think of a reason why it wouldn't work. Let me know if you want a test similar to the one I'm describing below.upload_pypi
to run unconditionally so that you can check that the dist/
directory contains the right things. Once you're convinced it works as expected, we can apply the following patch to make it run only under the appropriate circumstances:diff --git a/.github/workflows/build_wheels.yml b/.github/workflows/build_wheels.yml
index 750306a..23be339 100644
--- a/.github/workflows/build_wheels.yml
+++ b/.github/workflows/build_wheels.yml
@@ -306,6 +306,7 @@ jobs:
upload_pypi:
needs: [test_wheels]
runs-on: ubuntu-latest
+ if: github.event_name == 'release' && github.event.action == 'published'
steps:
- uses: actions/download-artifact@v4
with:
@@ -315,4 +316,7 @@ jobs:
mv dist/sdist/*.tar.gz dist/
mv dist/wheels-*/*.whl dist/
rmdir dist/{sdist,wheels-*}
- - run: ls -R dist
+ - uses: pypa/gh-action-pypi-publish@release/v1
+ with:
+ skip_existing: true
+ password: ${{ secrets.PYPI_PASSWORD }}
Closing in favor of #163
Replace #160 which was failing because of breaking changes in v4.