pablogsal
commented
1 month ago I cannot reproduce this:
$ ./python -m sysconfig | grep 'pydebug'
CONFIG_ARGS = "'--with-pydebug' '--with-assertions'"
$ ./python --version
Python 3.12.5+
$ git --no-pager diff --no-color
diff --git a/Modules/_heapqmodule.c b/Modules/_heapqmodule.c
index 00285ae01f8..d35e674f8bb 100644
--- a/Modules/_heapqmodule.c
+++ b/Modules/_heapqmodule.c
@@ -146,6 +146,7 @@ heappop_internal(PyObject *heap, int siftup_func(PyListObject *, Py_ssize_t))
/* raises IndexError if the heap is empty */
n = PyList_GET_SIZE(heap);
+ assert(n == 0);
if (n == 0) {
PyErr_SetString(PyExc_IndexError, "index out of range");
return NULL;
$ ./python -c 'import heapq; heapq.heappop([1,2,3])'
python: ./Modules/_heapqmodule.c:149: heappop_internal: Assertion `n == 0' failed.
[1] 1427571 IOT instruction (core dumped) ./python -c 'import heapq; heapq.heappop([1,2,3])'
$ pystack core ~/github/python/3.12/core.python.1000.5dbb8d0016f64d8eb106608c574a9089.1372147.1723205627000000 --native
Using executable found in the core file: /home/pablogsal/github/python/3.12/python
Core file information:
state: R zombie: True niceness: 0
pid: 1372147 ppid: 1331964 sid: 1331964
uid: 1000 gid: 1000 pgrp: 1372147
executable: python arguments: ./python -c import heapq; heapq.heappop([1,2,3])
The process died due receiving signal SIGABRT
Traceback for thread 1372147 [Has the GIL] (most recent call last):
(C) File "???", line 0, in _start (python)
(C) File "../csu/libc-start.c", line 360, in __libc_start_main@@GLIBC_2.34 (libc.so.6)
(C) File "../sysdeps/nptl/libc_start_call_main.h", line 58, in __libc_start_call_main (libc.so.6)
(C) File "./Programs/python.c", line 15, in main (python)
(C) File "Modules/main.c", line 767, in Py_BytesMain (python)
(C) File "Modules/main.c", line 743, in pymain_main (python)
(C) File "Modules/main.c", line 713, in Py_RunMain (python)
(C) File "Modules/main.c", line 624, in pymain_run_python (python)
(C) File "Modules/main.c", line 255, in pymain_run_command (python)
(C) File "Python/pythonrun.c", line 480, in PyRun_SimpleStringFlags (python)
(C) File "Python/pythonrun.c", line 1618, in PyRun_StringFlags (python)
(C) File "Python/pythonrun.c", line 1743, in run_mod (python)
(C) File "Python/pythonrun.c", line 1722, in run_eval_code_obj (python)
(Python) File "<string>", line 1, in <module>
(C) File "./Modules/clinic/_heapqmodule.c.h", line 68, in _heapq_heappop (_heapq.cpython-312d-x86_64-linux-gnu.so)
(C) File "./Modules/_heapqmodule.c", line 187, in _heapq_heappop_impl (_heapq.cpython-312d-x86_64-linux-gnu.so)
(C) File "./Modules/_heapqmodule.c", line 149, in _heapq__heappop_max_impl (_heapq.cpython-312d-x86_64-linux-gnu.so)
(C) File "/usr/src/debug/glibc/glibc/assert/assert.c", line 94, in _nl_load_domain.cold (libc.so.6)
(C) File "/usr/src/debug/glibc/glibc/stdlib/abort.c", line 79, in abort (libc.so.6)
(C) File "../sysdeps/posix/raise.c", line 26, in raise (libc.so.6)
(C) File "/usr/src/debug/glibc/glibc/nptl/pthread_kill.c", line 44, in __pthread_kill_implementation (libc.so.6)
ZeroIntensity
Is there an existing issue for this?
Current Behavior
Running with Python 3.12.5 (unreleased) compiled with
--with-pydebugand--with-assertionsseems to cause some odd behavior with PyStack, when the core file fails at an assertion.Earlier today, I noticed PyStack segfaulted on a core file that did this (although, I'm struggling to reproduce this again), and I also observed it to have some highlighting issues (but not segfault) on a different case (but still failing at an assertion).
I've emailed a core file containing the incorrect highlight to @godlygeek, but I'm still working on coming up with a reproducer for the segfault.
Expected Behavior
It shouldn't do that :stuck_out_tongue:
Steps To Reproduce
./configure --with-pydebug --with-assertionspystack core --native-allPystack Version
1.3.0
Python Version
3.12
Linux distribution
Arch Linux
Anything else?
No response