Closed gaborbernat closed 1 year ago
As far as I can tell, you've got a mix of manual changes and automatically generated changes, as well as functional changes and stylistic changes, all rolled into a single commit.
Nope, all was done automatically; minus a very few that ruff required to pass. ruff check --fix
automatically applies most of the changes, hard to separate them out 🤷 and probably not worth the effort.
It's very, very difficult to review this when all in one commit lines have been moved and changed, with some changes having been done manually and others having been done by automated tools. I'd like at least 4 separate commits here:
ruff
instead of flake8
and isort
ruff check --fix
pyproject-fmt
Plus separate commits for any other manual changes I didn't notice.
Let's forget it, too much effort. I'll spend my effort on other projects.
Thanks for the review though 🙏