bloomberg / pytest-memray

pytest plugin for easy integration of memray memory profiler
https://pytest-memray.readthedocs.io/en/latest/
Apache License 2.0
323 stars 23 forks source link

Use ruff instead of flake8 #79

Closed gaborbernat closed 1 year ago

gaborbernat commented 1 year ago
gaborbernat commented 1 year ago

As far as I can tell, you've got a mix of manual changes and automatically generated changes, as well as functional changes and stylistic changes, all rolled into a single commit.

Nope, all was done automatically; minus a very few that ruff required to pass. ruff check --fix automatically applies most of the changes, hard to separate them out 🤷 and probably not worth the effort.

godlygeek commented 1 year ago

It's very, very difficult to review this when all in one commit lines have been moved and changed, with some changes having been done manually and others having been done by automated tools. I'd like at least 4 separate commits here:

  1. The configuration changes to start using ruff instead of flake8 and isort
  2. The changes automatically made by ruff check --fix
  3. The changes automatically made by pyproject-fmt
  4. The changes manually made to the versions of our declared dependencies

Plus separate commits for any other manual changes I didn't notice.

gaborbernat commented 1 year ago

Let's forget it, too much effort. I'll spend my effort on other projects.

gaborbernat commented 1 year ago

Thanks for the review though 🙏