search

bloomberg / python-github-webhook

A framework for writing webhooks for GitHub, in Python.
https://bloomberg.github.io/python-github-webhook
Apache License 2.0
291 stars 69 forks source link

Missing Git tags #33

Open legoktm opened 6 months ago

legoktm commented 6 months ago

Hi! Thanks for creating this.

The only Git tag I see in this repo is for 1.0.2, however versions 1.0.3 and 1.0.4 have been pushed to PyPI. Could tags be pushed for this and releases going forwards? This will make it easier for people to reproduce and verify that the published PyPI package matches what is in Git.

P.S. I'm planning to package this for Debian as well: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1068354

legoktm commented 6 months ago

Unfortunately building from master (what should be 1.0.4) using python setup.py sdist gives me a different tarball:

user@dev ~/g/b/p/dist (master) [2]> tar -tf github-webhook-1.0.4.tar.gz 
github-webhook-1.0.4/
github-webhook-1.0.4/LICENSE
github-webhook-1.0.4/PKG-INFO
github-webhook-1.0.4/README.md
github-webhook-1.0.4/github_webhook/
github-webhook-1.0.4/github_webhook/__init__.py
github-webhook-1.0.4/github_webhook/webhook.py
github-webhook-1.0.4/github_webhook.egg-info/
github-webhook-1.0.4/github_webhook.egg-info/PKG-INFO
github-webhook-1.0.4/github_webhook.egg-info/SOURCES.txt
github-webhook-1.0.4/github_webhook.egg-info/dependency_links.txt
github-webhook-1.0.4/github_webhook.egg-info/requires.txt
github-webhook-1.0.4/github_webhook.egg-info/top_level.txt
github-webhook-1.0.4/setup.cfg
github-webhook-1.0.4/setup.py
github-webhook-1.0.4/tests/
github-webhook-1.0.4/tests/test_webhook.py

Now here's what I downloaded off of PyPI:

user@dev ~/tmp> wget https://files.pythonhosted.org/packages/1f/53/5f7bd98be1dfc4a1b0e202195b41bb8b6062496bc5e5aedea3e30aa38b07/github-webhook-1.0.4.tar.gz
--2024-04-04 16:27:15--  https://files.pythonhosted.org/packages/1f/53/5f7bd98be1dfc4a1b0e202195b41bb8b6062496bc5e5aedea3e30aa38b07/github-webhook-1.0.4.tar.gz
Resolving files.pythonhosted.org (files.pythonhosted.org)... 151.101.44.223, 2a04:4e42:b::223, 2a04:4e42:200::223, ...
Connecting to files.pythonhosted.org (files.pythonhosted.org)|151.101.44.223|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 4031 (3.9K) [application/x-tar]
Saving to: ‘github-webhook-1.0.4.tar.gz’

github-webhook-1.0. 100%[===================>]   3.94K  --.-KB/s    in 0s      

2024-04-04 16:27:15 (112 MB/s) - ‘github-webhook-1.0.4.tar.gz’ saved [4031/4031]

user@dev ~/tmp> tar -tf github-webhook-1.0.4.tar.gz 
github-webhook-1.0.4/
github-webhook-1.0.4/PKG-INFO
github-webhook-1.0.4/README.md
github-webhook-1.0.4/github_webhook/
github-webhook-1.0.4/github_webhook/__init__.py
github-webhook-1.0.4/github_webhook/webhook.py
github-webhook-1.0.4/github_webhook.egg-info/
github-webhook-1.0.4/github_webhook.egg-info/PKG-INFO
github-webhook-1.0.4/github_webhook.egg-info/SOURCES.txt
github-webhook-1.0.4/github_webhook.egg-info/dependency_links.txt
github-webhook-1.0.4/github_webhook.egg-info/requires.txt
github-webhook-1.0.4/github_webhook.egg-info/top_level.txt
github-webhook-1.0.4/setup.cfg
github-webhook-1.0.4/setup.py

Note how the PyPI tarball is missing the tests, while my build from master does. I don't think anything nefarious is happening here, but it would be good to get it straightened out.