Fixed the move semantics related and other issues reported by the newer clang compiler.

bloomberg / quantum

Powerful multi-threaded coroutine dispatcher and parallel execution engine

Apache License 2.0

572 stars 94 forks source link

Fixed the move semantics related and other issues reported by the newer clang compiler. #153

Open safaruqi opened 2 years ago

safaruqi commented 2 years ago

Issue number of the reported bug or feature request: #150

Describe your changes Fixed all of the move semantics related and other issues reported by the newer clang compiler.

Testing performed Was able to run all the included tests successfully which tests the whole fixture and primitives.

Additional context

safaruqi commented 2 years ago

Travis Ci passed for g++ C++ standard 11, 14, & 17. For clang it passed for C++ 14 & 17 but is failing for c++11. WIl look at it when I find some time next.

accelerated commented 2 years ago

@safaruqi @arosenzweig3 any updates on this merge? Seems like it's holding up some folks...

arosenzweig3 commented 2 years ago

This looks good to me, just getting another set of eyes on it before we merge.