search

bloomberg / stricli

Build complex CLIs with type safety and no dependencies
https://bloomberg.github.io/stricli
Apache License 2.0
630 stars 7 forks source link

Broken links after refreshing the documentation page #13

Closed haoqunjiang closed 1 week ago

haoqunjiang commented 1 week ago

Describe the bug

After refreshing the "Overview" page on the documentation website, the links to "Alternatives" became 404.

To Reproduce

  1. Go to https://bloomberg.github.io/stricli/docs/getting-started/overview
  2. Refresh the page
  3. Click the link in the sentence "Check out the alternatives considered for a concrete breakdown."
  4. See error

Expected behavior The link shouldn't error after refreshing.

Screenshots Before refreshing:

image

After refreshing

image

Note the URLs changed in both the address bar and the in-page hyperlink.

Environment (please complete the following information):

Additional context

I'll send a PR soon.

molisani commented 1 week ago

Refreshing no longer adds a trailing slash to the URL (causing the links to become broken). Manually navigating to the URL with a trailing slash results in a page with broken links but I think that's just a consequence of docusaurus + github pages.