bloomberg / vault-auth-spire

vault-auth-spire is an authentication plugin for Hashicorp Vault which allows logging into Vault using a Spire provided SVID.
Apache License 2.0
41 stars 8 forks source link

Renames TrustFileSource to FileTrustSource #6

Closed dennisgove closed 5 years ago

dennisgove commented 5 years ago

Signed-off-by: Dennis Gove dgove1@bloomberg.net

Describe your changes The name of file and struct for (old) TrustFileSource felt awkward so I've renamed it to FileTrustSource. I think this name is clearer.

I've also added comments in the file describing what a FileTrustSource is intended to do.

Testing performed Manual testing to ensure the project builds, can be loaded and enabled as a plugin in vault, and properly verifies SVIDs using file trust sources.

Additional context Long term when a SPIRE trust source is added the name and intention will be clearer if it is SpireTrustSource.