search

bloombloombloom / Bloom

A debug interface for AVR-based embedded systems development on GNU/Linux.
https://bloom.oscillate.io/
Other
64 stars 3 forks source link

Add missing includes to fix build #86

Closed jpf91 closed 10 months ago

jpf91 commented 10 months ago

Hi there,

first of all great work on this project! I tried to get avarice working with debugwire but wasn't very successful. Then I found this project by chance and it improved the whole AVR experience on linux a lot for me :-)

When trying to compile on latest fedora, the project failed to build however. It seems some includes in some files are missing. Probably new compilers are a bit more picky or the system headers did include those headers before. The changes here fix the build for fedora 38. Fedora rawhide / 39 has another issue, but I'll open a new bug report for that.

navnavnav commented 10 months ago

Hey, thanks for this. Out of curiosity, what compiler (and version) were you using?

Also, did you encounter issues with the Fedora (RPM) package available via the downloads page? Is that why you built from source? I know some people just prefer to build things from source, and that's fine, but it would be good to know if there's something wrong with the RPM package that I ship.

navnavnav commented 10 months ago

Sorry for changing the base branch of your PR. The master branch is used to hold the latest stable release. The develop branch is where the unreleased changes go, and then they're merged into master when I'm ready to push a new release.

Don't worry about the conflicts in your PR, I'll sort it :)

I've been using GCC 12 to build recent releases of Bloom, and that doesn't present me with any errors so I'm in the process of building GCC 13 now, to see if that's the one being picky. Once I've replicated the issue, I'll get these changes in.

BTW if you're building from source, may I suggest that you give the develop branch a try? You'll likely need to copy these changes over, but that branch has some unreleased, breaking changes (for v1.0.0) that would be cool to get some feedback on. Also, a fair bit of tidying has been done in that branch, so may be a little easier to work with :)

navnavnav commented 10 months ago

Have confirmed the missing includes are an issue with GCC 13+.

As I can't make changes to the source branch, I've pushed your changes directly to the develop branch - they'll be included in the next release (v1.0.0). Have updated the release notes with credit to @jpf91.

Will close this PR now. Thanks again for raising :)