search

bloomkd46 / homebridge-iRobot

A homebridge plugin for controlling iRobot devices
Apache License 2.0
62 stars 14 forks source link

Change accessory type to Switch #172

Open r2shyyou opened 1 year ago

r2shyyou commented 1 year ago

Is your feature request related to a problem? Please describe:

i have a ceiling fan connected to Homekit and since the iRobot accessory type is fan, if i say, “hey Siri, turn on the fan,” both the fan & the iRobot turn on.

Describe the solution you'd like:

change the iRobot accessory type from Fan to Switch, or allow the user to select

Describe alternatives you've considered:

No response

Additional context:

No response

Node Version (optional):

No response

NPM Version (optional):

No response

Homebridge Version (optional):

No response

Plugin Version:

2.1.16

Operating System (optional):

No response

r2shyyou commented 1 year ago

@bloomkd46 looks like there's already a pull request for this: https://github.com/bloomkd46/homebridge-iRobot/pull/167

victorBaro commented 1 year ago

Anyway to speed up the process to merge it and make it available? It's very annoying

bloomkd46 commented 1 year ago

Although it isn't a switch due to its lack of customization, I did change it from a fan. Feel free to try the latest beta: npm

Slug-Life commented 1 year ago

Just gave the latest beta a try and got it working after a few minor hiccups. My previously configured robot didn't show up when upgrading from v3 -> v4. Manual configuration also doesn't seem to work for me be but I didn't have any issues using my iRobot login.

TBH I'm not sure I love the accessory type as a TV. I see the appeal of having everything in one place under the inputs, but you're not longer able to have automations for things like the bin being full.

I still think that ideally it would be a main switch with sub switches for actions and sensors for statuses. Then the user can chose to show it all as one tile or separately in HomeKit. Options in the Homebridge config to show what switches or sensors are displayed would be amazing.

bloomkd46 commented 1 year ago

I am intending to reintroduce the contact sensors for events, I just haven’t wrote it yet

Slug-Life commented 1 year ago

Cool, I'll play with it some more. They way it always shows the current status the the tile is pretty nice.

Slug-Life commented 1 year ago

I have to say after using it some more, having the device type as a TV is really neat. So far it works well and I haven't had any issues with Siri commands affecting TVs in the same room.