Bug Report: - Githubissues

siobhanellis commented 1 year ago

Describe The Bug:

I have 3 Roomba's (980, i7, j7) and the automatic config only finds the first

To Reproduce:

Install. Reboot Homebridge (V1.6.0), and it shows only 1 robot (i7).

Currently 1 robot has the wrong IP address (I'm having difficulty setting it up on my network at home, but it is still configure. The j7 works from the app, but I can't get it to work in this plugin.

Expected behavior:

It would find all 3 Roomba's

Logs:

[iRobot] Loading accessory from cache: Robbie
[12/9/2022, 3:30:33 PM] [iRobot] Logging into iRobot...
[12/9/2022, 3:30:36 PM] [iRobot] Configuring roomba: Robbie
[12/9/2022, 3:30:36 PM] [iRobot] Configuring roomba: Roomba
[12/9/2022, 3:30:46 PM] [iRobot] Failed to configure roomba: Roomba see below for details
[12/9/2022, 3:30:46 PM] [iRobot] No Roomba Found With Blid: 3165050841132540

[12/9/2022, 3:30:46 PM] [iRobot] Configuring roomba: Daneel Olivaw
[12/9/2022, 3:30:56 PM] [iRobot] Failed to configure roomba: Daneel Olivaw see below for details
[12/9/2022, 3:30:56 PM] [iRobot] No Roomba Found With Blid: 32F90039FE684894AF22170E914074DC

[12/9/2022, 3:30:56 PM] [iRobot] Disabling Unconfigured Roomba: Roomba
[12/9/2022, 3:30:56 PM] TypeError: Cannot read properties of undefined (reading 'name')
    at getRoombas (/usr/local/lib/node_modules/homebridge-irobot/src/getRoombas.ts:50:63)
    at iRobotPlatform.discoverDevices (/usr/local/lib/node_modules/homebridge-irobot/src/platform.ts:65:36)
    at HomebridgeAPI.<anonymous> (/usr/local/lib/node_modules/homebridge-irobot/src/platform.ts:34:12)
    at HomebridgeAPI.emit (node:events:532:35)
    at HomebridgeAPI.signalFinished (/usr/local/lib/node_modules/homebridge/src/api.ts:275:10)
    at Server.start (/usr/local/lib/node_modules/homebridge/src/server.ts:190:14)

Config:

{
            "name": "iRobot",
            "email": "****@hotmail.com",
            "password": "******-******-******",
            "roombas": [
                {
                    "autoConfig": true,
                    "info": {
                        "ver": 2
                    }
                }
            ],
            "manualDiscovery": false,
            "lowBattery": 20,
            "offAction": "pause:dock",
            "status": "cycle:clean",
            "eveStatus": "inverted:cycle:clean",
            "bin": "filter:contact",
            "ignoreMultiRoomBin": true,
            "hideStuckSensor": false,
            "disableMultiRoom": false,
            "platform": "iRobotPlatform"
        }

Node Version:

16.14.0

NPM Version:

8.3.1

Homebridge Version:

1.6.0

Plugin Version:

2.1.16

Operating System:

MacOS

bloomkd46 commented 1 year ago

Please try the latest beta: