blooparksystems / website

Odoo Website builder related addons
GNU Affero General Public License v3.0
10 stars 33 forks source link

Avoid editing of the SEO Field on website homepage #22

Closed fczaja closed 8 years ago

fczaja commented 9 years ago

SEO URL field must be removed from the Home page

Impacted versions:

The home page has no URL, so the "SEO URL" Promote / Optimize SEO field should be hidden or not rendered. Should be also work for multi websites in one DB - should be tested

Current behavior:

Currently, the "SEO URL field" on the home page can be seen and it can be a URL are entered. Plotting a URL to the home page is redirected to the new URL and Promote panel no longer works.

Expected Behavior:

The "SEO URL field" i Promote / Optimize SEO field will be removed so that there are no changes can be made.

rruebner commented 9 years ago

If #25, #26 and #27 are finished I will do the review.

rruebner commented 9 years ago

@kaerdsar Your solution works for "/" but not for the default odoo homepage route "/page/homepage/". I don't know if there is a better solution than to exclude simply "/page/homepage/" next to "/". Maybe you can use the key field "website.hompage" of the ir.ui.view record in some way.

kaerdsar commented 9 years ago

@rruebner now it also works with '/page/homepage', you can see it in the commit https://github.com/blooparksystems/website/commit/34e271a66a1ae9d3aeb7a890b553341fe9089859

rruebner commented 8 years ago

Review was fine :+1:. Code changes were already merged.