search

blopker / superduper

iOS and Android app to manage your ebike.
MIT License
31 stars 6 forks source link

Better error when GPS is not enabled #41

Open Bellador opened 1 month ago

Bellador commented 1 month ago

Describe the bug After the recent update I have similar issues as the last issue reported. My Super73 S2 is no longer listed (in line with the mentioned release notes) but the scan fails to re-identify and pair with my bike. I followed the entire troubleshooting guide / FAQ on this repo but to no avail. Location permissions are set, bluetooth is on, even bluetooth tethering is enabled. Tried restarting phone and bike multiple times as well as reinstalling the app. No success. I need the bike for my daily commute so I am in desperate need of a fix. At the very beginning (2023) I had similar connectivity issues already with the original Super73 app (no longer installed), but managed to get it fixed with the help of the Super73 subreddit, but which nolonger exists since it was unmonitored. Would it be possible to revert to the previous version of the app for my phone? Any assistance is highly appreciated :)

To Reproduce Steps to reproduce the behavior:

  1. Go to 'SuperDuper' app
  2. Tap on 'Start scan'
  3. No error feedback, but bike is not detected

Expected behavior Proper detection and connection to bike

Screenshots If applicable, add screenshots to help explain your problem.

Bike (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

Bellador commented 1 month ago

Excuse the fuzz. Managed to solve the issue. Besides enabling bluetooth, it also required enabling GPS. The latter was not required before which is why I did not consider it - despite giving the app the corresponding permissions. This might help someone else in the future with a similar issue. I can recommend the Super73 discord (since subreddit is dead) or in this case https://eusupport.super73.com/hc/en-us/articles/24283658760851-SUPER73-App-Troubleshooting

blopker commented 1 month ago

Hey! Thanks for surfacing this. Permissions should not have changed, and I believe GPS/location had always been needed since it's required to do Bluetooth scans. In any case, I'll update the FAQ to make sure people check permissions when troubleshooting.

Bellador commented 1 month ago

Before I really only ever needed Bluetooth. I hardly ever have GPS enabled, only specifically for navigation. Anyhow, thanks for updating the FAQ. I also want to use this opportunity to thank you and the other maintainer(s) for their great work - I appreciate you :)!

blopker commented 1 month ago

Hm, it shouldn't need GPS actually on, just location permissions because apps can track people's locations with Bluetooth scans.

I'll look into this next time I get a chance.

blopker commented 1 month ago

I've updated the relevant FAQ section. I have learned that the new code I'm using to handle Bluetooth does require GPS to be on now for some devices. This needs a better error in the app, but it's sadly not something I can fix.