search

blossom-project / blossom

Blossom is a Java framework based on Spring-Boot which enables you to realize your projects quickly and smoothly. It comes with several modules and tools made to ease and speed up your development process.
http://blossom-project.com
Apache License 2.0
21 stars 21 forks source link

Force latin1 encoding for job names and groups in trigger history #186

Closed RLejolivet closed 6 years ago

RLejolivet commented 6 years ago

Fix #185

MariaDB 10.1 using debian/ubuntu packages uses utf8mb4 by default, but keeps the 767 bytes limit for indexes.

Other installation methods (using mariadb-provided packages, or docker) still use latin1 by default, which does not encounter the problem. MariaDB 10.2 and up have a higher limit, and do not fail even with utf8 encoding. MySQL does not encounter the problem since its default is still latin1 until mysql 8.0, which accepts longer keys.

This "fix" forces latin1 encoding for MariaDB 10.1 only, on the "job_name" and "job_group" columns, so the key size remains small enough.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 52.924% when pulling af7148a578e17a091c1e67e5d34fd127f818758f on RLejolivet:trigger-history-index-size into 13768d24ac1bcbc3347dc4bf5d41247484a7c1ab on blossom-project:master.

RLejolivet commented 6 years ago

@mgargadennec Not sure how to go about liquibase changelog author: I changed it since the changelog was split and different enough, but most of the changelog was still the original table creation.