search

blowdart / idunno.Authentication

A filled with self-loathing implementation of Basic Authentication, and Certificate Authentication to make me feel like a real security person, all for for ASP.NET Core
Apache License 2.0
409 stars 70 forks source link

Produce 3.0 and 3.1 packages for basic auth #46

Closed blowdart closed 4 years ago

blowdart commented 4 years ago

From @yang-er's pull request.

blowdart commented 4 years ago

@yang-er I updated the appveyor environment to VS2019 to get both Core 3.0 and 3.1 installer and the packages have been produced. Do you want to see if those work for you? You can grab pre-release packages from the current appveyor build for master.

yang-er commented 4 years ago

It works well! Thanks.

blowdart commented 4 years ago

Oh good.

I want to address some performance issues in cert auth if I can this week, so expect a supported package towards the end of the week.

fagnercarvalho commented 4 years ago

I'm seeing in the README that only version 2.2.2 targets .NET Core 3.1 but I don't see 2.2.2 in NuGet, only 2.2.1. Is 2.2.1 supposed to support 3.1 or not? I'm getting HTTP 421 when running 2.2.1 in 3.1.

blowdart commented 4 years ago

That’s because master is the branch under development. You can take the current build assets to test it but it won’t be out until I do some work on certificate auth.

From: Fagner Nunes Carvalho notifications@github.com Sent: Friday, February 28, 2020 7:07:32 PM To: blowdart/idunno.Authentication idunno.Authentication@noreply.github.com Cc: Barry Dorrans github.com@idunno.org; Assign assign@noreply.github.com Subject: Re: [blowdart/idunno.Authentication] Produce 3.0 and 3.1 packages for basic auth (#46)

I'm seeing in the README that only version 2.2.2 targets .NET Core 3.1 but I don't see 2.2.2 in NuGet, only 2.2.1. Is 2.2.1 supposed to support 3.1 or not? I'm getting HTTP 421 when running 2.2.1 in 3.1.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/blowdart/idunno.Authentication/issues/46?email_source=notifications&email_token=AAGCNCX2L3LMVGR4U7R6SNLRFB5XJA5CNFSM4K4GMYCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENK7ITA#issuecomment-592835660, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAGCNCQQUBNCAUDYEOARHLLRFB5XJANCNFSM4K4GMYCA.

fagnercarvalho commented 4 years ago

Got it, thank you for the fast reply!

blowdart commented 4 years ago

Fixed as in https://github.com/blowdart/idunno.Authentication/commit/c09e90f21adeb8957c3c42abd1ad5f86c433803d

Released as part of https://github.com/blowdart/idunno.Authentication/releases/tag/v2.2.2

blowdart commented 4 years ago

@fagnercarvalho @yang-er these should now be available on nuget for you; https://www.nuget.org/packages/idunno.Authentication.Basic/