search

blowfishpro / B9PartSwitch

A Kerbal Space Program plugin designed to implement switching of part meshes, resources, and nodes
GNU Lesser General Public License v3.0
50 stars 33 forks source link

Remote version file is missing #205

Closed HebaruSan closed 3 years ago

HebaruSan commented 3 years ago

The version file's URL property currently is this, which doesn't exist:

Checking https://s3.amazonaws.com/blowfish-ksp-b9partswitch-avc , there are version files for other game versions, but not 1.10.1. Looks like maybe it never got uploaded?

Note that making multiple version-specific remote version files somewhat defeats the purpose of remote version files, because you lose the ability to notify about newer versions that are only reflected in newer remote version files. Recommend using one single remote version file to get back this capability.

Tagging @blowfishpro because I'm not sure whether GitHub will send a notification otherwise.

https://github.com/DasSkelett/AVC-VersionFileValidator by @DasSkelett can help a lot with catching things like this.

blowfishpro commented 3 years ago

Good catch, probably got missed when I moved over to Github actions

HebaruSan commented 3 years ago

Did this actually get fixed? The URL is still a 404:

https://s3.amazonaws.com/blowfish-ksp-b9partswitch-avc/ksp-1.10.1/B9PartSwitch.version

EDIT: Ahh, ksp-1.10.1 will be replaced with latest in some future update. Thanks and never mind.

blowfishpro commented 3 years ago

Yeah that should be working, it has been a while since I released though

blowfishpro commented 3 years ago

(btw if you're curious there's an AWS lambda function that copies the version file to latest if it is in fact the latest version)