search

blowfishpro / SimpleAdjustableFairings

A Kerbal Space Program plugin enabling easy to use, visually appealing fairings made from modular sections
GNU Lesser General Public License v3.0
5 stars 6 forks source link

TweakScale support for SimpleAdjustableFairings #15

Open judicator opened 3 years ago

judicator commented 3 years ago

Fairings walls and caps masses are scaled proportional to scale squared (it's hardcoded). I think, it's a good approach. TweakScale patches for individual fairing parts are in SimpleAdjustableFairings-KWFairings repo.

blowfishpro commented 3 years ago

I think this works, I wonder if we could just scale the root transform for each fairing segment though.

judicator commented 3 years ago

I think this works, I wonder if we could just scale the root transform for each fairing segment though.

Do you think this could solve TweakScale + B9PartSwitch + SAF issue? Or just for making code more clean?

blowfishpro commented 3 years ago

Do you think this could solve TweakScale + B9PartSwitch + SAF issue? Or just for making code more clean?

Just to make the code more clean, generally it would be nice to have the internals not care about scale and just multiply everything at the end.

blowfishpro commented 3 years ago

Also due to Tweakscale issues in 1.11 I'm going to hold off on testing and merging this but I haven't forgotten.

linuxgurugamer commented 2 years ago

Have the Tweakscale issues been solved so this can be tested and then hopefully merged?