bloxbean / yaci

A Cardano Mini Protocols implementation in Java

MIT License

25 stars 3 forks source link

[FEAT] N2N TxSubmission #63

Closed nemo83 closed 7 months ago

nemo83 commented 7 months ago

Feat N2N TxSubmission

This is the implementation of the Node-to-Node mini protocol TxSubmission.

Worth to mention that I've replaced the initial HashMap containing ids and bytes of the txs as I wanted to preserve order to addition (as it actually matters).

I've streamed real node mempool via N2C to a local node via N2N TxSubmission and it has been running for a few hours w/o errors or disconnecting.

nemo83 commented 7 months ago

Updated most comments, before closing I need to:

[x] Check how to properly set the Era in the serialization code. Where can I get such info?
[x] Test that after replacing Vector w/ ConcurrentLinkedQueue it all still works (as I've changed the code removing transactions)

satran004 commented 7 months ago

Thanks @nemo83 . Please check my era specific comment above.

Is it possible to add an integration test for Tx submission? Something like LocalTxSubmissionClientIT.

satran004 commented 7 months ago

@nemo83 I tried it and I was able to successfully submit and execute my transaction

So, the callback methods in listener are only to notify if the transaction has been successfully pulled by the remote node. right?