Swiping is dope. Super natural spring. I really fuck with that. Similar to the other repositories, all comments here are ease of use or aesthetic related. The engine runs well!
Page number confusion. I wanted to see if currentPage was zero indexed or 1 indexed and it wasn't in the documentation. Easy thing to add.
The app crashes when you enter a negative current page. Consider making current page an unsigned int, so change Int to UInt. I think that makes more sense in this context bc you could never have a negative page count.
The app crashes when you enter a non-valid current page. Thoughts on just making it instead go to the nearest page? If you enter page 9 and there are 6 pages just send it to page six.
An aesthetic point, but I did very much expect some dots at the bottom of the view. At least something to indicate the type of element I was dealing with. My first step was to I look at the init's & the modifiers to try to see if I was simply missing that option and didn't see anything.
It was really difficult to figure out the default height and width of the view. It was also difficult to figure out if that height and width was inherited from the subviews. Unsure the best way to communicate that information, but definitely confusing.
We should toss in a sexy dummy view that'd be cool.
Swiping is dope. Super natural spring. I really fuck with that. Similar to the other repositories, all comments here are ease of use or aesthetic related. The engine runs well!
Page number confusion. I wanted to see if
currentPagewas zero indexed or 1 indexed and it wasn't in the documentation. Easy thing to add.The app crashes when you enter a negative current page. Consider making current page an unsigned int, so change
InttoUInt. I think that makes more sense in this context bc you could never have a negative page count.The app crashes when you enter a non-valid current page. Thoughts on just making it instead go to the nearest page? If you enter page 9 and there are 6 pages just send it to page six.
An aesthetic point, but I did very much expect some dots at the bottom of the view. At least something to indicate the type of element I was dealing with. My first step was to I look at the init's & the modifiers to try to see if I was simply missing that option and didn't see anything.
It was really difficult to figure out the default height and width of the view. It was also difficult to figure out if that height and width was inherited from the subviews. Unsure the best way to communicate that information, but definitely confusing.
We should toss in a sexy dummy view that'd be cool.