search

blt04 / puppet-rvm

A puppet module for installing and using RVM (Ruby Version Manager)
Other
242 stars 280 forks source link

Puppet 2.6+ introduce run stages -> install all in one pass #29

Closed phuongnd08 closed 12 years ago

phuongnd08 commented 12 years ago

Puppet 2.6 introduced run stages (See http://docs.puppetlabs.com/guides/language_guide.html#run-stages) Can it possibly used to make everything happen in one pass?

blt04 commented 12 years ago

Thanks for the suggestion. This should be done automatically now. You no longer need to wrap RVM configuration in $rvm_installed if blocks.

shamil commented 12 years ago

I'm getting error with that, that says: cannot find stage 'main' on line 3 in system.pp. I'm using puppet 2.7.1 and no noop

blt04 commented 12 years ago

@shamil, try adding include rvm before include rvm::system in your manifest files, or upgrade to Puppet 2.7.10 or newer.

shamil commented 12 years ago

Thanks, that helped :) But it seems $rvm_installed == 'true' still required...

blt04 commented 12 years ago

Unfortunately with --noop, that is the case.

However, if you run without --noop and without $rvm_installed=='true' it will actually install everything in one pass.

shamil commented 12 years ago

I'm not running with noop, the agent runs it through puppet-master, I've added include rvm before the include rvm:system, it seems now that I'm not getting error, but if I remove $rvm_installed == 'true' i get an error: Could not find a default provider for rvm_gem

blt04 commented 12 years ago

Perhaps there is an issue with Puppet 2.7.1, as it works on 2.7.10. So either: run in two passes with $rvm_installed == 'true', upgrade to 2.7.10, or open a separate issue and I'll see what I can do.

shamil commented 12 years ago

I'll upgrade to newer Puppet, many thanks for your help!