blt04 / puppet-rvm

A puppet module for installing and using RVM (Ruby Version Manager)
Other
242 stars 280 forks source link

rvm doesn't like being called from a full path #30

Closed joehillen closed 12 years ago

joehillen commented 12 years ago

I kept getting this error during every puppet run:

notice: /Stage[main]//Node[test]/Server::Www[stable]/Rvm_system_ruby[ruby-1.9.2-p180]/default_use: default_use changed 'false' to 'true'

It looks like rvm doesn't like to be called using it's full path, and so the default was never getting set.

This seems to fix the issue, but I'm willing to bet that this change will cause some other issue.

Do you think this an ok change?

joehillen commented 12 years ago

Ok, that didn't fix it.

If I run sudo puppet agent --test I get:

 notice: /Stage[main]//Node[test]/Server::Www[stable]/Rvm_gemset[ruby-1.9.2-p180@stable]: Dependency Rvm_system_ruby[ruby-1.9.2-p180] has failures: true
 warning: /Stage[main]//Node[test]/Server::Www[stable]/Rvm_gemset[ruby-1.9.2-p180@stable]:Skipping because of failed dependencies
notice: /Stage[main]//Node[test]/Server::Www[stable]/Exec[compile-css]: Dependency Rvm_system_ruby[ruby-1.9.2-p180] has failures: true
 warning: /Stage[main]//Node[test]/Server::Www[stable]/Exec[compile-css]: Skipping because of failed dependencies
notice: /Stage[main]//Node[test]/Server::Www[stable]/Rvm_gem[ruby-1.9.2-p180@stable/bundler]: Dependency Rvm_system_ruby[ruby-1.9.2-p180] has failures: true
warning: /Stage[main]//Node[test]/Server::Www[stable]/Rvm_gem[ruby-1.9.2-p180@stable/bundler]: Skipping because of failed dependencies

But if I run it as root (i.e. sudo su -), it workes fine.

joehillen commented 12 years ago

nevermind, turns out I should be using rvmsudo

blt04 commented 12 years ago

Hi Joe. Thanks for the pull request. I believe the default_use bugs should be fixed in the latest commits.