search

blt04 / puppet-rvm

A puppet module for installing and using RVM (Ruby Version Manager)
Other
242 stars 280 forks source link

Centralise module filename #90

Closed kronn closed 4 years ago

kronn commented 11 years ago

This builds upon and thereby replaces #89 and #88. Thanks @adamcohen and @inetdavid.

I put the decision which directory and (following from that) filename the compiled module is found at.

I also reduced the number of templates involved so that centos and ubuntu are more likely to be in sync.

mshirley commented 11 years ago

You made changes to manifests/passenger/apache/ubuntu/post.pp for the "creates" statement using the new compiled_module_fn variable but didn't make the same change for the manifests/passenger/apache/centos/post.pp file line 17.

https://github.com/kronn/puppet-rvm/blob/fac362a647ecdecbf8010ee9a7226667a65dffa3/manifests/passenger/apache/centos/post.pp#L17

kronn commented 11 years ago

Thanks for the pointer, @mshirley. That pretty much proves that my machines run Ubuntu, doesn't it?

I noticed that the CentOS-post manifest does not provide restart hooks for apache. I don't know the specifics of CentOS in that regard, so I did not change that.