search

blt950 / vPilot-Pushover

Plugin for vPilot to Pushover vPilot and Hoppie messages
GNU General Public License v3.0
13 stars 5 forks source link

Added Telegram sending option + Disconnect message #18

Open rensdebee opened 3 months ago

rensdebee commented 3 months ago

Added the free option of sending commands via a Telegram bot

Also added a Flag for a message when disconnected this fixes #17

First time working/building in C# so nice learning experience

blt950 commented 3 months ago

Thanks for the PR, I haven't had the chance to review it yet due to time and not having telegram myself to verify this.

I'm thinking this functionality is interesting, but I'd require perhaps a rebrand and rewrite of the main project in a way where it's not longer vPilot-Pushover as it's telegram as well now. I'm thinking perhaps the user should choose which notification method they want and config accordingly.

This means we should probably split notification methods into its own folder and classes and use the correct class upon start.

I'll try look into this during the summer, unless you feel the call and beat me to it.